-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crater runs for Rust 1.38.0 #63628
Comments
@craterbot run name=beta-1.38-1 start=1.37.0 end=beta-2019-08-13 mode=build-and-test cap-lints=warn p=10 |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
@craterbot run name=beta-1.38-rustdoc-1 start=1.37.0 end=beta-2019-08-13 mode=rustdoc cap-lints=warn p=5 |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
@craterbot run name=beta-1.38-rustdoc-1 p=0 Downgrading rustdoc crater run priority as it usually doesn't catch anything too severe and we have a long Crater queue. |
🚨 Error: missing start toolchain 🆘 If you have any trouble with Crater please ping |
@craterbot name=beta-1.38-rustdoc-1 p=0 |
📝 Configuration of the ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
cc @petrochenkov heads up, there are a bunch of macro / derive related regressions errors here, e.g.: |
Yeah, there were a lot of changes in this area. Here are all the errors:
|
Does crater respect |
Caused by #63449. |
This may be something caused by derive hygienization (#63462 or some of the earlier PRs) and/or this PR - #63501. |
Expected breakage from #62133, attributes of the form |
Regression from #63114, fixed in #63717. |
Expected breakage of an unstable feature ( |
Minimized reproduction, run with /// #
///
/// ident ident
fn f() {} Apparently something makes this comment look like code to Actually, stable rustdoc also gives an error for this, from what I tried locally, not sure why it passed on crater. |
This is due to #63083.
Relevant code: https://docs.rs/tarrasque-macro/0.10.0/src/tarrasque_macro/lib.rs.html#193.
Appears to be fixed in the recently published |
The comment ( See also: |
This is the most hilarious case so far. Code in
and it broke when visibility resolution switched to a different algorithm ("early resolution") in #63400, which doesn't have this bug. So, the regression is a bugfix and this bug needs to be fixed in other contexts as well, #63882 is the tracking issue for that. |
|
Minimized: use Enum::Debug;
#[derive(Debug)] // Add some more derives if the error does not reproduce
enum Enum {
Debug
} This is a regression from #63248, and #63867 works in the same direction but hasn't landed yet. Basically, the import is blocked until the derive is expanded and the derive is blocked until the import is resolved, so we have a deadlock. This worked previously, because we did some things in less principled way (textual comparisons instead of resolution), which allowed us to produce the This is fixable in principle, by making the expansion infra more fine-grained (introducing some new "resolved, but not yet ready for expansion" states), but I'm afraid that's not something that could be backported to beta. |
@petrochenkov all this triage look great, but it's not easily actionable if it's all done in this issue. Could you move each regression to its own issue, and maybe add checkboxes in your list here to track the progress? |
Ok, I'll make separate issues once I've looked at the remaining regressions. UPD: Done. |
This is a regression from these series of pretty-printing improvements - #62393, #62574, #62667. Tokens are printed more precisely now, so Procedural macro |
One more victim to the pretty-printing changes (#62667), whitespace-related in this case. Here's what the macro does: if last.to_string() != "{ }" {
/* report error */
} Pretty unreliable check, isn't it? |
Yeah, those both seem like reliance on implementation details
…On Sun, Aug 25, 2019, 9:07 AM Vadim Petrochenkov ***@***.***> wrote:
custom attribute panicked
[INFO] [stderr] Compiling display-as v0.4.6 (/opt/crater/workdir)
[INFO] [stderr] error: custom attribute panicked
[INFO] [stderr] --> tests/format_as.rs:104:5
[INFO] [stderr] |
[INFO] [stderr] 104 | #[with_template("Foo " self.0)]
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: message: with_template must be applied to an impl that ends in '{}', not { }
One more victim to the pretty-printing changes (#62393
<#62393>, #62574
<#62574>, #62667
<#62667>), whitespace-related in
this case.
Here's what the macro does:
if last.to_string() != "{ }" {
/* report error */
}
Pretty unreliable check, isn't it?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#63628?email_source=notifications&email_token=AALVMK3YC63MNEHSLR4DLLLQGKU4TA5CNFSM4IMEXQT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CWMYI#issuecomment-524641889>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALVMK5UANDNY6WDSLSOAL3QGKU4TANCNFSM4IMEXQTQ>
.
|
All of the 62 regressions are due to old versions of I think we should be able to fix this by special casing the comma token during token stream pretty-printing and not printing the space before it. |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
Did anyone triage the regressions not related to the frontend? 1.38 was released a few weeks ago so it's too late to do it now, but if they weren't triaged that means some kind of a process break. |
I suspect no -- I thought all regressions were triaged (and issues opened, etc.) |
Made an issue - #65577. |
cc @rust-lang/release
The text was updated successfully, but these errors were encountered: