Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#60584 #64480

Closed
rust-highfive opened this issue Sep 15, 2019 · 1 comment · Fixed by #64487
Closed

rls no longer builds after rust-lang/rust#60584 #64480

rust-highfive opened this issue Sep 15, 2019 · 1 comment · Fixed by #64487
Assignees
@Xanewok
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60584, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @jonas-schievink, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2019
@jonas-schievink
Copy link
Contributor

Upstream fix has landed: rust-lang/rls#1553

@Xanewok Xanewok mentioned this issue Sep 15, 2019
Merged
@bors bors closed this as completed in 3e3e06d Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RLS Xanewok/rust
3 participants
@jonas-schievink @Xanewok @rust-highfive