-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stray "not covered" diagnostic in JSON output #64769
Comments
Can you check if this reproduces for Seems to be a cross crate issue? #![allow(unused)]
enum O<T> { Some(T), None, }
use O::*;
fn main() {
let x = Some(1);
let Some(y) = x;
} shows Relevant code:
cc @estebank |
It's likely pointing at a
This is probably coming from desugaring. We can add a test around the |
Oh, I see. Yea, it works correctly for your example. I guess it is trying to point to the definition of |
How critical is this? Namely, how quickly do we need a fix? Fixing for this one test is a small pr, fixing the general case will be more arduous, I think. |
For me, not critical at all. It would be nice to eventually get it fixed, but there is absolutely no rush. |
Triage: I believe this is fixed? I'm seeing |
Thanks for checking @steveklabnik, I think the dummy span issue was resolved by #70199. |
Since #64271, the E0005 error has begun emitting a strange "not covered" span in the JSON output. This does not appear in the normal "human" rendered output.
Sample code:
With
--error-format=json
, this includes the following span which looks broken to me:For tools that consume JSON output, this results in a strange message being displayed.
cc @Centril
The text was updated successfully, but these errors were encountered: