Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lint to force adding at least one test for each error code? #64811

Closed
GuillaumeGomez opened this issue Sep 26, 2019 · 2 comments · Fixed by #65135
Closed

Add a lint to force adding at least one test for each error code? #64811

GuillaumeGomez opened this issue Sep 26, 2019 · 2 comments · Fixed by #65135
Assignees
@GuillaumeGomez
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

A lot of error codes currently don't have ui tests nor long error explanation, therefore we cannot know if they're still thrown by the compiler which isn't an ideal situation... Should we add lint/check for this?

cc @rust-lang/compiler
@jonas-schievink jonas-schievink added A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2019
@estebank
Copy link
Contributor

Introducing it will be hard to do precisely because I'm sure a non insignificant amount of them are unreachable now.

@GuillaumeGomez
Copy link
Member Author

The lint can add a list of error codes to ignore in a first time. I'm currently going through error codes and adding explanations/tests.

@GuillaumeGomez GuillaumeGomez self-assigned this Oct 5, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 5, 2019
Merged
@bors bors closed this as completed in ecd6229 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check for missing tests for error codes GuillaumeGomez/rust
3 participants
@estebank @jonas-schievink @GuillaumeGomez