-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to disable rustdoc keyboard shortcuts #65211
Comments
I can add a setting for it if you want. But do we want to disable all keyboard shortcuts or only a few of them? For example, I doubt that 'S' is conflicting in any layout (but I might be wrong!). |
This isn't about layouts, this is about custom shortcuts. So yes, disable all of them. |
But then some features won't be accessible anymore (well, I doubt that the '?' menu would interest people who don't care about provided shortcuts). Also, should we keep the text of the search bar as is even though the shortcuts are disabled? |
I think not referring to the shortcuts when they are disabled makes sense; a single button is sufficient IMO as Manish said. If features aren't available without the shortcut, that seems a bit weird, but I'd need a list of such features since I can't think of any other than ? which is obviously useless if shortcuts are off. Gmail, for example, provides a single button (https://support.google.com/mail/answer/6594?hl=en). |
Well then, I'll add the option and not change anything else then. |
…cut, r=Dylan-DPC Add option to disable keyboard shortcuts in docs Fixes rust-lang#65211. r? @Manishearth
Some people have custom OS or browser-level shortcuts, providing a way to disable these makes it easier for them
The text was updated successfully, but these errors were encountered: