Remove disambiguator from intra doc link text

[dtolnay]

/// Trait: [`trait@Name`], fn: [`fn@Name`]
pub struct S;

pub trait Name {}

#[allow(non_snake_case)]
pub fn Name() {}

This is currently rendered as:

The links point to the right place (the trait and the fn respectively) but I believe the link text should be just "Name" for both.

Discovered in #65336.

Mentioning the tracking issue: #43466

This issue has been assigned to @jyn514 via this comment.

[GuillaumeGomez]

I can do it if you want but maybe you prefer doing it?

[dtolnay]

I definitely don't prefer doing it. 😉 Feel free to go ahead. Thanks!

[GuillaumeGomez]

Ok haha. Will try to do it not too far into the future.

[jyn514]

@rustbot claim

[jyn514]

So, I tried implementing this just now and it's not possible with the current pulldown-cmark API. The issue is that while broken_link_callback can return a new title (for when you hover) and a new URL, it cannot change the text that is rendered for shortcut reference links: [fn@Name]. See https://github.com/raphlinus/pulldown-cmark/blob/master/src/parse.rs#L2213.

Maybe we could ask pulldown to extend the API to allow this? I had trouble with the last PR I made though, the link parsing is very complicated.

[GuillaumeGomez]

I think it'll be the best situation to directly improve the parser's API, indeed.