Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Move src/test/run-fail to src/test/ui #65440

Closed
Centril opened this issue Oct 15, 2019 · 8 comments · Fixed by #71185
Closed

Cleanup: Move src/test/run-fail to src/test/ui #65440

Centril opened this issue Oct 15, 2019 · 8 comments · Fixed by #71185
Assignees
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Oct 15, 2019

We have a small amount of tests in src/test/run-fail; these should be moved over to various directories in src/test/ui depending on what the test is about. (See #65438 (comment) for one example of moving run-fail/ tests to ui/.) When moving each test in src/test/run-fail you have to add // run-fail to the top of each file.

cc @varkor

This issue has been assigned to @nvlbg via this comment.

@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Oct 15, 2019
@nvlbg
Copy link

nvlbg commented Oct 15, 2019

I'd like to work on this. First time contributor so it make take me some time to finish it.

@Centril
Copy link
Contributor Author

Centril commented Oct 15, 2019

@rustbot assign @nvlbg

@rustbot rustbot self-assigned this Oct 15, 2019
@estebank
Copy link
Contributor

Note that some of those tests are still there due to non-determinism in the output across multiple platforms. Those should be restricted to run on only one platform to be able to do this move.

@varkor
Copy link
Member

varkor commented Oct 15, 2019

Those should be restricted to run on only one platform to be able to do this move.

We should make sure to cross reference these with issues too.

@nvlbg
Copy link

nvlbg commented Oct 16, 2019

@estebank are these tests marked somehow? Also how are tests restricted to a single platform?

Edit: I found the following comments in the tests:

// ignore-cloudabi no std::process
// ignore-cloudabi no std::process
// ignore-cloudabi no std::process
// ignore-cloudabi no std::process
// ignore-cloudabi no std::process
// ignore-emscripten Needs threads
// ignore-emscripten Needs threads.
// ignore-emscripten Needs threads.
// ignore-emscripten
// ignore-emscripten
// ignore-emscripten
// ignore-cloudabi no std::env

Are those the flags that some platforms need to be ignored?

@estebank
Copy link
Contributor

I believe those in particular aren't the ones u was thinking about, but they are marked with ignore- tags. I think they might be either ignore-x86 or ignore-musl, something along those lines.

@Centril
Copy link
Contributor Author

Centril commented Oct 16, 2019

Generally speaking, a trial and error approach should work here... work through the tests a few at a time and see what will go through CI.

@JesterOrNot
Copy link

I would like to help with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants