-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: Move src/test/run-fail to src/test/ui #65440
Comments
I'd like to work on this. First time contributor so it make take me some time to finish it. |
Note that some of those tests are still there due to non-determinism in the output across multiple platforms. Those should be restricted to run on only one platform to be able to do this move. |
We should make sure to cross reference these with issues too. |
@estebank are these tests marked somehow? Also how are tests restricted to a single platform? Edit: I found the following comments in the tests:
Are those the flags that some platforms need to be ignored? |
I believe those in particular aren't the ones u was thinking about, but they are marked with ignore- tags. I think they might be either ignore-x86 or ignore-musl, something along those lines. |
Generally speaking, a trial and error approach should work here... work through the tests a few at a time and see what will go through CI. |
I would like to help with this |
We have a small amount of tests in
src/test/run-fail
; these should be moved over to various directories insrc/test/ui
depending on what the test is about. (See #65438 (comment) for one example of moving run-fail/ tests to ui/.) When moving each test insrc/test/run-fail
you have to add// run-fail
to the top of each file.cc @varkor
This issue has been assigned to @nvlbg via this comment.
The text was updated successfully, but these errors were encountered: