Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for improper ctypes in all "stable ABIs" #65867

Closed
hanna-kruppe opened this issue Oct 27, 2019 · 2 comments · Fixed by #65134
Closed

Check for improper ctypes in all "stable ABIs" #65867

hanna-kruppe opened this issue Oct 27, 2019 · 2 comments · Fixed by #65134
Assignees
@davidtwco
Labels
A-FFI Area: Foreign function interface (FFI) A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@hanna-kruppe
Copy link
Contributor

hanna-kruppe commented Oct 27, 2019 •
edited
Loading

We should also run the lint for other stable (non-rustc-specific) ABIs such as win64, sysv, aapcs, interrupt ABIs, etc.
@hanna-kruppe hanna-kruppe mentioned this issue Oct 27, 2019
Merged
@jonas-schievink jonas-schievink added A-FFI Area: Foreign function interface (FFI) A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Oct 27, 2019
@davidtwco davidtwco self-assigned this Oct 27, 2019
@cuviper
Copy link
Member

cuviper commented Oct 29, 2019

Do you have an example that doesn't check? In #64641 I specifically excluded Rust ABIs from the check, because before it was checking all extern blocks regardless of chosen ABI. Maybe there's another path that's checking differently.

@hanna-kruppe
Copy link
Contributor Author

Hm, it might very well have been a code path that was only introduced in #65134 (I turned a review comment there into this issue). So I'll close this now.

bors added a commit that referenced this issue Nov 4, 2019
@bors
Auto merge of #65134 - davidtwco:issue-19834-improper-ctypes-in-exter…
f5f1ae4 
…n-C-fn, r=rkruppe

improper_ctypes: `extern "C"` fns

cc #19834. Fixes #65867.

This pull request implements the change [described in this comment](#19834 (comment)).

cc @rkruppe @varkor @shepmaster
bors added a commit that referenced this issue Nov 6, 2019
@bors
Auto merge of #65134 - davidtwco:issue-19834-improper-ctypes-in-exter…
3f0e164 
…n-C-fn, r=rkruppe

improper_ctypes: `extern "C"` fns

cc #19834. Fixes #65867.

This pull request implements the change [described in this comment](#19834 (comment)).

cc @rkruppe @varkor @shepmaster
@SimonSapin SimonSapin mentioned this issue Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidtwco davidtwco

Labels
A-FFI Area: Foreign function interface (FFI) A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improper_ctypes: extern "C" fns davidtwco/rust
4 participants
@cuviper @davidtwco @jonas-schievink @hanna-kruppe