Skip to content

Fix name of method symbols (__extensions__) #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue May 19, 2013 · 5 comments
Closed

Fix name of method symbols (__extensions__) #6602

brson opened this issue May 19, 2013 · 5 comments
Labels
A-codegen Area: Code generation C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented May 19, 2013

Examples of method names.

+ 1.97% coroutine-call coroutine-call [.] rt::comm::__extensions__::try_recv_4749::anon::expr_fn_4752 ▒
+ 1.94% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::sched::__extensions__::meth_24322::resume_task_from_queue::_98d7edf54cd03ca::_07pre ▒
+ 1.92% coroutine-call librustrt.so [.] upcall_call_shim_on_rust_stack ▒
+ 1.76% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::uv::idle::__extensions__::idle_cb::_102cdea612f47982::_07pre ▒
+ 1.74% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::sched::__extensions__::meth_24416::enqueue_cleanup_job::_5bddff916a99173::_07pre ▒
+ 1.72% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] _ZN2rt5sched11local_sched19rust_get_rt_tls_key16_585f1373eca8c836_07preE@plt ▒
+ 1.72% coroutine-call [vdso] [.] 0x00007fff543ff894 ▒
+ 1.53% coroutine-call coroutine-call [.] rt::comm::__extensions__::try_recv_4641::_2880c2c982aa795::_00 ▒
+ 1.34% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::uv::idle::__extensions__::close_cb::__rust_stack_shim ▒
+ 1.34% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::sched::__extensions__::meth_20718::resume_task_immediately::_cb9890c6b348544::_07pre ▒
+ 1.32% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::sched::__extensions__::meth_16410::schedule_task::_cb9890c6b348544::_07pre ▒
+ 1.31% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::sched::__extensions__::schedule_task::anon::expr_fn_24410 ▒
+ 1.30% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::uv::idle::__extensions__::idle_cb::__rust_stack_shim ▒
+ 1.29% coroutine-call coroutine-call [.] rt::comm::__extensions__::try_recv_4641::anon::expr_fn_4644 ▒
+ 1.25% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::uv::uvio::__extensions__::callback::anon::expr_fn_25096 ▒
+ 1.11% coroutine-call libcore-c3ca5d77d81b46c1-0.7-pre.so [.] rt::uv::uvio::__extensions__::meth_24318::callback::_cad8f2676061ef2a::_07pre 

Use a meaningful symbol name instead of __extensions__::meth_INTEGER.

@brson
Copy link
Contributor Author

brson commented May 19, 2013

Nominating.

@graydon
Copy link
Contributor

graydon commented May 23, 2013

nominating for what milestone?

@graydon
Copy link
Contributor

graydon commented May 23, 2013

is this an artifact of when we had named impls?

@graydon
Copy link
Contributor

graydon commented May 23, 2013

accepted for production-ready milestone

@bblum
Copy link
Contributor

bblum commented Jul 22, 2013

I think this is such an artifact as graydon asks. I don't know if it's strictly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants