Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a crate for common AST definitions #66149

Closed
Centril opened this issue Nov 6, 2019 · 3 comments
Closed

Introduce a crate for common AST definitions #66149

Centril opened this issue Nov 6, 2019 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Nov 6, 2019

Context: #65884 (comment)

For example:

  • Mutability is shared between AST / HIR / ...
  • CaptureBy and CaptureClause fill the same role.
  • Constness
  • Unsafety
  • Movability and GeneratorMovability (?)
  • BindingMode

Suggested crate name rustc_ast_common.

cc @oli-obk
@Centril Centril added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2019
@cjgillot
Copy link
Contributor

cjgillot commented Nov 9, 2019

Hi,

I would like to do that if you don't mind.
I will try to submit a draft during the weekend.

@cjgillot cjgillot mentioned this issue Nov 9, 2019
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Nov 10, 2019

wrt to creating a global crate, we should hold up on that. Merging types where no new crate is needed is uncontroversial I believe, but adding a new crate just for this should be discussed first

bors added a commit that referenced this issue Nov 11, 2019
@bors
Auto merge of #66252 - cjgillot:trees, r=oli-obk
56237d7 
Merge repeated definitions

Step forward on #66149

I may need further context to understand the need for a separate crate.

Also, please tell me if you think of other definitions to merge.
@Centril
Copy link
Contributor Author

Centril commented Dec 14, 2019

Closing as moot for the time being.

@Centril Centril closed this as completed Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oli-obk @Centril @cjgillot