Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn macro_legacy_warnings into a hard error #67098

Closed
Centril opened this issue Dec 6, 2019 · 0 comments · Fixed by #69129
Closed

Turn macro_legacy_warnings into a hard error #67098

Centril opened this issue Dec 6, 2019 · 0 comments · Fixed by #69129
Assignees
@Centril
Labels
A-parser Area: The parsing of Rust source code to an AST C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Dec 6, 2019

That is, land the commit: 7972462

Context: #66994 (comment)

Leaving this here as a reminder to myself and cc @estebank.
@Centril Centril added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-parser Area: The parsing of Rust source code to an AST T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2019
@Centril Centril self-assigned this Dec 6, 2019
@Centril Centril mentioned this issue Dec 6, 2019
Merged
@Centril Centril mentioned this issue Feb 13, 2020
Merged
Centril added a commit to Centril/rust that referenced this issue Feb 17, 2020
@Centril
Rollup merge of rust-lang#69129 - Centril:macro-legacy-errors, r=petr…
3122c80 
…ochenkov

Transition macro_legacy_warnings into a hard error

Fixes rust-lang#67098.

r? @petrochenkov
@bors bors closed this as completed in 0176a9e Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Centril Centril

Labels
A-parser Area: The parsing of Rust source code to an AST C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transition macro_legacy_warnings into a hard error Centril/rust
1 participant
@Centril