Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching on a str should compare content, not identity #673

Closed
marijnh opened this issue Jul 12, 2011 · 1 comment
Closed

Matching on a str should compare content, not identity #673

marijnh opened this issue Jul 12, 2011 · 1 comment

Comments

@marijnh
Copy link
Contributor

marijnh commented Jul 12, 2011

Either that, or we should disallow it altogether. The current behaviour, where you can put a str in a case pattern, but there's no way to guarantee that any other str will equal the literal you put in there, seems bogus.
@marijnh
Copy link
Contributor Author

marijnh commented Jul 12, 2011

This was a nonsense issue. Matching actually does the right thing. I am unsure why == does a different thing, but that's another story.

@marijnh marijnh closed this as completed Jul 12, 2011
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@bors
Auto merge of rust-lang#673 - g2p:fallocate-flags, r=alexcrichton
57413b8 
Add all current fallocate flags

Also move them to the common Linux module, as they are not platform-specific.
See include/uapi/linux/falloc.h.
pdietl pushed a commit to pdietl/rust that referenced this issue Apr 23, 2020
@Centril
Merge pull request rust-lang#673 from ehuss/fix-abbr
63b07f2 
Fix abbr tag.
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Add get type analyzer method to C API (rust-lang#673)
bb70046 
* Add get type analyzer method to C API

* Add inverted phi type handler
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @tedinski
Fix rmc --gen-c (rust-lang#673)
6d2f28a 
There was a regression introduced by b6e2bcad6cb that broke rmc --gen-c.
This change fixes that. I am also fixing a random white space from my
previous commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marijnh