-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase in compilation times with newest beta & nightly #67454
Labels
I-compiletime
Issue: Problems and improvements with respect to compile times.
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
regression-from-stable-to-nightly
Performance or correctness regression from stable to nightly.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
Thanks to cargo-bisect-rustc, the first nightly with the regression is nightly-2019-12-14. nightly-2019-12-13 was still working fine. |
Thanks for the report! I'm about to go on vacation for 6 weeks, so I will file a PR to back out #66405 before I go. |
Thanks, and enjoy your holidays! |
sdroege
added a commit
to sdroege/rustc-perf
that referenced
this issue
Dec 22, 2019
sdroege
added a commit
to sdroege/rustc-perf
that referenced
this issue
Dec 22, 2019
bors
added a commit
that referenced
this issue
Jan 1, 2020
Revert parts of #66405. Because PR #66405 caused major performance regressions in some cases. That PR had five commits, two of which affected performance, and three of which were refactorings. This change undoes the performance-affecting changes, while keeping the refactorings in place. Fixes #67454. r? @nikomatsakis
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this issue
Jan 23, 2020
Because it caused major performance regressions in some cases. That PR had five commits, two of which affected performance, and three of which were refactorings. This change undoes the performance-affecting changes, while keeping the refactorings in place. Fixes rust-lang#67454.
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I-compiletime
Issue: Problems and improvements with respect to compile times.
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
regression-from-stable-to-nightly
Performance or correctness regression from stable to nightly.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Description
This was initially reported in Marwes/combine#278.
I hit an important increase in compilation times on beta & nightly with a
particular configuration using
combine-3.8.1
since the recent version updatesin the Rust toolchains.
I tried building an example without
combine
in order to submit it torustc
but it turns out not to be trivial. I ran into this as a side effect in CI and
can't spend much time investigating ATM, sorry.
From the CI logs I have at hand, the issue was not present as of:
rustc 1.41.0-nightly (fdc0011 2019-12-02).
Reduced example
Here is an example with which I was able to reproduce the issue:
Toolchain versions
The toolchain used for these tests are those available as of 2019/12/20:
Compilation times
For each test,
cargo clean
was run before building in debug mode.With
message(..)
Without
message(..)
"Interestingly", removing the
.message(..)
line reduces compilation timessignificantly.
The text was updated successfully, but these errors were encountered: