Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit & Harden run-pass tests for #![feature(bindings_after_at)] #67523

Closed
1 task done
Centril opened this issue Dec 22, 2019 · 4 comments · Fixed by #69810
Closed
1 task done

Audit & Harden run-pass tests for #![feature(bindings_after_at)] #67523

Centril opened this issue Dec 22, 2019 · 4 comments · Fixed by #69810
Assignees
@rustbot
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-bindings_after_at `#![feature(bindings_after_at)]` requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Dec 22, 2019 •
edited
Loading

The feature bindings_after_at which allows for x @ Some(y) patterns, is implemented in #66296. The PR doesn't have as good coverage of the dynamic semantics as we might like. Once the PR lands, we should try to improve things before we stabilize the feature.

Notable tests to include:

cc @pnkfelix @matthewjasper #65490

This issue has been assigned to @thekuom via this comment.
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. requires-nightly This issue requires a nightly compiler in some way. F-bindings_after_at `#![feature(bindings_after_at)]` and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Dec 22, 2019
@Centril
Copy link
Contributor Author

Centril commented Dec 24, 2019

This is now unblocked as #66296 has landed.

@Centril Centril mentioned this issue Dec 24, 2019
Closed
@JohnTitor JohnTitor added A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jan 19, 2020
@thekuom
Copy link
Contributor

thekuom commented Mar 5, 2020

I would like to work on this one 👍

@Centril
Copy link
Contributor Author

Centril commented Mar 6, 2020

Go for it :)

@rustbot assign @thekuom

@rustbot rustbot self-assigned this Mar 6, 2020
@thekuom thekuom mentioned this issue Mar 7, 2020
Merged
@Centril
Copy link
Contributor Author

Centril commented Mar 8, 2020

Now that #69690 has landed, I think we can close this once #69810 also lands.

Centril added a commit to Centril/rust that referenced this issue Mar 8, 2020
@Centril
Rollup merge of rust-lang#69810 - thekuom:test/67523-dynamic-semantic…
72ad36f 
…s-bindings-after-at, r=Centril

test(bindings_after_at): add dynamic drop tests for bindings_after_at

Fixes rust-lang#67523.
Working towards rust-lang#65490.
@bors bors closed this as completed in 49c82d1 Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-bindings_after_at `#![feature(bindings_after_at)]` requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(bindings_after_at): add dynamic drop tests for bindings_after_at thekuom/rust
4 participants
@Centril @thekuom @JohnTitor @rustbot