Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIR inlining checks for impossible condition #67863

Closed
bjorn3 opened this issue Jan 4, 2020 · 1 comment · Fixed by #78966
Closed

MIR inlining checks for impossible condition #67863

bjorn3 opened this issue Jan 4, 2020 · 1 comment · Fixed by #78966
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-mir-opt Area: MIR optimizations C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jan 4, 2020

rust/src/librustc_mir/transform/inline.rs

Lines 218 to 222 in abf2e00

// Cannot inline generators which haven't been transformed yet
if callee_body.yield_ty.is_some() {
debug!(" yield ty present - not inlining");
return false;
}

The generator is always transformed, as only the output of optimized_mir is passed to should_inline.
@bjorn3
Copy link
Member Author

bjorn3 commented Jan 4, 2020

@rustbot modify labels: +A-mir +C-cleanup

@rustbot rustbot added A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jan 4, 2020
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 4, 2020
@jonas-schievink jonas-schievink added the A-mir-opt Area: MIR optimizations label Mar 29, 2020
@tmiasko tmiasko mentioned this issue Nov 12, 2020
Merged
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 12, 2020
@m-ou-se
Rollup merge of rust-lang#78966 - tmiasko:inline-never, r=oli-obk
d3a7a5d 
Never inline C variadics, cold functions, functions with incompatible attributes ...

... and fix generator inlining.

Closes rust-lang#67863.
Closes rust-lang#78859.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Nov 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#78966 - tmiasko:inline-never, r=oli-obk
2362b5a 
Never inline C variadics, cold functions, functions with incompatible attributes ...

... and fix generator inlining.

Closes rust-lang#67863.
Closes rust-lang#78859.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Nov 13, 2020
@Dylan-DPC
Rollup merge of rust-lang#78966 - tmiasko:inline-never, r=oli-obk
3b4b47f 
Never inline C variadics, cold functions, functions with incompatible attributes ...

... and fix generator inlining.

Closes rust-lang#67863.
Closes rust-lang#78859.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Nov 14, 2020
@Dylan-DPC
Rollup merge of rust-lang#78966 - tmiasko:inline-never, r=oli-obk
591a39a 
Never inline C variadics, cold functions, functions with incompatible attributes ...

... and fix generator inlining.

Closes rust-lang#67863.
Closes rust-lang#78859.
@bors bors closed this as completed in 6be44ed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-mir-opt Area: MIR optimizations C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Never inline C variadics, cold functions, functions with incompatible attributes ... tmiasko/rust
3 participants
@jonas-schievink @bjorn3 @rustbot