Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make I/O threadsafe #6843

Closed
brson opened this issue May 30, 2013 · 3 comments
Closed

Make I/O threadsafe #6843

brson opened this issue May 30, 2013 · 3 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@brson
Copy link
Contributor

brson commented May 30, 2013

uv-based I/O is bound to a specific scheduler but tasks are not. This means that when a task goes to perform I/O it needs to check whether it is on the correct scheduler and if not, send itself as a message to the correct scheduler. Types that implement rtio traits will need to contain a SchedHandle to their home scheduler.
@brson brson mentioned this issue May 30, 2013
Closed
30 tasks
@huonw
Copy link
Member

huonw commented Aug 5, 2013

Triage 2013-08-05: grep seems to suggest that this (rtio-trait-implementors having a SchedHandle) isn't the case yet. (Although there has been a lot of work in the last 2 months, so the design plan may've changed.)

Is this still an issue, @brson or @bblum?

@anasazi
Copy link
Contributor

anasazi commented Aug 21, 2013

I believe this has been resolved by #8631. Can we close @brson?

@alexcrichton
Copy link
Member

We now having the HomingIO trait, closing this.

flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 11, 2021
@bors
Auto merge of rust-lang#6843 - Jarcho:match_on_same_arms_macro, r=Man…
7be3a32 
…ishearth

Compare empty blocks for equality based on tokens

fixes: rust-lang#1390

This only considers empty blocks for now, though we should also catch something like this:

```rust
match 0 {
    0 => {
        do_something();
        trace!(0);
        0
    }
    1 => {
        do_something();
        trace!(1);
        1
    }
    x => x,
}
```

As far as I can tell there aren't any negative effects on other lints. These blocks only happen to be the same for a given compilation, not all compilations.

changelog: Fix `match_on_same_arms` and others. Only consider empty blocks equal if the tokens contained are the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @brson @anasazi @huonw