Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more sensible heuristic to detect default-target #69

Closed
graydon opened this issue Jun 28, 2010 · 2 comments
Closed

Use a more sensible heuristic to detect default-target #69

graydon opened this issue Jun 28, 2010 · 2 comments
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 28, 2010

Rustboot probes /System/Library to determine if it's on OSX vs. Linux. This is a ridiculous sniffing heuristic, to say the least. Write something more robust for detecting meaningful unix flavours (those that effect backend / objfile choices).
@pcwalton
Copy link
Contributor

pcwalton commented Aug 3, 2010

Now uses uname -s.

@pcwalton
Copy link
Contributor

Marking this fixed.

@evanmcc evanmcc mentioned this issue Apr 3, 2012
Closed
oli-obk pushed a commit to oli-obk/rust that referenced this issue Jul 19, 2017
@solson
Merge pull request rust-lang#69 from oli-obk/master
c148d88 
don't force allocations for most casts
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@steveklabnik
Merge pull request rust-lang#69 from eddyb/patch-1
96e976d 
Statements do not have types.
@Amanieu Amanieu mentioned this issue Jun 12, 2023
Open
@adamgemmell adamgemmell mentioned this issue Apr 11, 2024
Merged
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Sep 6, 2024
@carolynzech @tautschnig @zhassan-aws
align_offset Contracts (rust-lang#69)
bc7bce7 
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Michael Tautschnig <mt@debian.org>
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Co-authored-by: Michael Tautschnig <tautschn@amazon.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @pcwalton