-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LZ4 or Snappy instead of Deflate in metadata #6902
Comments
I don't know how bootstrapping this change is going to work, either. |
I think the eventual ideal move here is to compress each item's metadata and ast separately and fix how we load metadata to only decompress the necessary items. But picking a different compressor, or different encoding, is certainly also fine. |
Yeah, transitioning away from ebml would be great. Decoding it and especially converting from big endian is a sore spot. Of course, reading as little endian right now isn't any better because it still does conversion and doesn't optimize for little endian systems, but that optimization is at least possible. |
Currently decompressing the metadata is ~10% (more on slower computers) of the build time of small crates (eg, the tests). Switching to a faster algorithm would bring that down. I think LZ4 is that algorithm:
This has two parts:
The text was updated successfully, but these errors were encountered: