Skip to content

rust configure is misinvoking sed -i on Mac OS X #6929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pnkfelix opened this issue Jun 4, 2013 · 3 comments
Closed

rust configure is misinvoking sed -i on Mac OS X #6929

pnkfelix opened this issue Jun 4, 2013 · 3 comments

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Jun 4, 2013

These lines

        # Hack the tools Makefile to turn off the clang build
        sed -i 's/clang//g' tools/Makefile

are not correct for sed on OS X, where the extension for the backup files is required when using -i

% sed --help
sed: illegal option -- -
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]

I believe this is what causes the following output during configure:

sed: 1: "tools/Makefile": undefined label 'ools/Makefile'
@brson
Copy link
Contributor

brson commented Jun 4, 2013

Clang is not in the tree now, so this configure step has no effect (unless ones workspace still has clang sitting around).

@pnkfelix
Copy link
Member Author

pnkfelix commented Jun 6, 2013

Odd, I had thought I had seen it on relatively fresh workspaces. I guess I will double-check.

@pnkfelix
Copy link
Member Author

Okay, I was confused by @brson's comment. I thought he was saying that this line should not be firing, but I think he is saying that it can be safely removed. (Thus I am not crazy, and one will indeed still see the message on fresh workspaces, or non-fresh ones, really anywhere you run configure on OS X.)

Anyway, I'll remove the line.

@bors bors closed this as completed in 32586fa Jul 19, 2013
@pnkfelix pnkfelix removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 10, 2023
needless_range_loop: improve documentation

fixes rust-lang#6929

changelog: [`needless_range_loop`]: improve documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants