-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected panic in rustc with async_stream #69355
Comments
The root cause seems to be a build error inside of the async_stream::stream! macro:
first_pt is supposed to be an Option, but I've just put in a Point3Msg instead. Instead of getting a build error as expected, we get this panic. If I fix the build error by putting in an Option, the panic goes away. |
Could you please try this on nightly and see if it reproduces? Additionally, could you try to create a reproducer that fits in the playground (without using any external crate save for the standard library)? Thanks. |
I'm pretty sure this error is specifically because of async_stream::stream!, which is a proc macro hack. I'm not reproducing this panic on the latest nightly, though. Instead I get this output:
This is in line with what I expect, so it does look like this is fixed in nightly. |
How about beta? Maybe there's a PR we should backport? |
Same panic on latest beta.
By the way, the tooling for Rust is the best I've ever seen. I can't think of any other language where I can try three different versions of the language on any platform with only three command line calls. Everybody who worked on rustup and cargo deserves every reward you could possibly give them. |
Let's find the PR that fixed this on nightly and see if we should beta backport. @rustbot ping icebreakers-cleanup-crew |
Hey Cleanup Crew ICE-breakers! This bug has been identified as a good cc @AminArria @chrissimpkins @DutchGhost @elshize @ethanboxx @h-michael @HallerPatrick @hdhoang @hellow554 @imtsuki @jakevossen5 @KarlK90 @LeSeulArtichaut @matheus-consoli @mental32 @nmccarty @Noah-Kennedy @pard68 @PeytonT @pierreN @Redblueflame @RobbieClarken @RobertoSnap @robjtede @senden9 @shekohex @sinato @spastorino @turboladen @woshilapin @yerke |
If anyone's working on that now, I was able to narrow it down between 2020-01-14 (panic) and 2020-02-01(regular fail); will continue shortly if no one comes up with the answer soon. |
I did a bisect test with PANIC = baseline, NORMAL-FAIL-TO-COMPILE = regression. Based on the dates from @elshize (thanks). Command used:
Bisect Output:eed12bc finished with exit code Some(101). Regression found in the compilersearched nightlies: from nightly-2020-01-14 to nightly-2020-02-01 |
Could the fix PR be #68611? Seems likely given its title |
That's the only plausible PR that could have fixed this. As it is already beta/stable-accepted, there's nothing left to be done here. Thanks y'all. |
I got this rustc panic when trying to compile:
bug_sample.zip
Simple crate is attached. It's an attempt at generating a tonic client from protobuffer files.
The text was updated successfully, but these errors were encountered: