Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy-driver no longer builds after rust-lang/rust#69950 #69957

Closed
rust-highfive opened this issue Mar 12, 2020 · 0 comments · Fixed by #69923
Closed

clippy-driver no longer builds after rust-lang/rust#69950 #69957

rust-highfive opened this issue Mar 12, 2020 · 0 comments · Fixed by #69923
Assignees
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @flip1995
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #69950, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2020
@JohnTitor JohnTitor mentioned this issue Mar 12, 2020
Merged
@matthiaskrgr matthiaskrgr mentioned this issue Mar 12, 2020
Merged
bors added a commit that referenced this issue Mar 14, 2020
@bors
Auto merge of #69923 - matthiaskrgr:submodule_upd, r=Dylan-DPC
0f1e814 
submodules: update clippy from 329923e to fdce47b

Changes:
````
add CR feedback
Improve documentation
Use `edition:2018` flag more widely
Update tests/ui/needless_doc_main.rs
Move links to the end of each chapter on adding_lints
Move links to the end of each chapter on CONTRIBUTING
Clean-up adding_lints.md
Clean-up CONTRIBUTING.md
needless_doc_main: only check rust code
Use `node_type_opt` over `node_type`
Fix doc
Fix ICE with trivial_bounds feature
clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy.
update rust-lang.github.io to rustc-dev-guide.rust-lang.org
Improve placeholder in map_unit_fn
Fix match single binding when in a let stmt
Improve error messages for {option,result}_map_unit_fn
Mention the setup instructions in CONTRIBUTING
redundant_pattern: take binding (ref, ref mut) into account in suggestion.
check_pat: delay creation of the "normal" vec until we reach the branch where is is actually needed
deps: bump itertools 0.8 -> 0.9
add lint on File::read_to_string and File::read_to_end
transition rustc-guide to rustc-dev-guide
Rename macro_use_import -> macro_use_imports
warn on macro_use attr
Fix deploy script for tag deploys
````

Fixes #69957
@bors bors closed this as completed in 66949a7 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

@Manishearth Manishearth

@yaahc yaahc

@phansch phansch

@mcarton mcarton

@llogiq llogiq

@flip1995 flip1995

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy from 329923ed to fdce47ba matthiaskrgr/rust
9 participants
@oli-obk @Centril @Manishearth @yaahc @phansch @mcarton @llogiq @rust-highfive @flip1995