Skip to content

rustpkg::tests::test_package_request_version fails on Linux #7006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 8, 2013 · 6 comments
Closed

rustpkg::tests::test_package_request_version fails on Linux #7006

catamorphism opened this issue Jun 8, 2013 · 6 comments

Comments

@catamorphism
Copy link
Contributor

(From a commit I'm about to re-approve.) I don't know why, and can't get the VPN to work so I can experiment on the Linux bot.
@ghost ghost assigned catamorphism Jun 8, 2013
@alexcrichton alexcrichton mentioned this issue Jun 11, 2013
Closed
@catamorphism
Copy link
Contributor Author

In the logs for #7040, this also failed on Mac

@alexcrichton
Copy link
Member

I'm not sure if this would be related, but it looks like it's contacting github which I've seen fail on the bots occasionally. Maybe sporadic failures could be github network trouble?

@catamorphism
Copy link
Contributor Author

@alexcrichton Could be. I'm not sure what to do about it, though; github can be flaky, but I want to have tests for remote packages.

@alexcrichton
Copy link
Member

Is this still an issue? I thought I saw a commit go by awhile back which used a local repo instead of a remote git repo. If we still use a remote, though, carry on :)

@catamorphism
Copy link
Contributor Author

Somehow, this test lost its #[test] attribute. Re-testing.

@catamorphism
Copy link
Contributor Author

This can close when #8570 lands

@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue May 20, 2021
@bors
Auto merge of rust-lang#7216 - ThibsG:OptionIfLetElse7006, r=llogiq
44e0747 
Stop linting `else if let` pattern in [`option_if_let_else`] lint

For readability concerns, it is counterproductive to lint `else if let` pattern.
Unfortunately the suggested code is much less readable.

Fixes: rust-lang#7006

changelog: stop linting `else if let` pattern in [`option_if_let_else`] lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @catamorphism