Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only one try build can happen at the same time on GHA #70569

Closed
pietroalbini opened this issue Mar 30, 2020 · 0 comments · Fixed by #70628
Closed

Only one try build can happen at the same time on GHA #70569

pietroalbini opened this issue Mar 30, 2020 · 0 comments · Fixed by #70628
Assignees
@pietroalbini
Labels
A-github-actions Area: GitHub Actions (GHA) C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@pietroalbini
Copy link
Member

On Azure Pipelines we can run as many try builds as we want, since cancelbot only looks at the auto branch. On GitHub Actions instead we kill the build if a new commit is pushed on all workflows, including try. We should avoid using the cancel-outdated-builds action on the try branch.
@pietroalbini pietroalbini added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-github-actions Area: GitHub Actions (GHA) labels Mar 30, 2020
@pietroalbini pietroalbini mentioned this issue Mar 31, 2020
Merged
@pietroalbini pietroalbini self-assigned this Apr 1, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 2, 2020
@bors
Auto merge of rust-lang#70628 - pietroalbini:gha-multiple-tries, r=Ma…
0f72ce1 
…rk-Simulacrum

GHA: enable running multiple try builds at the same time

While for auto, try and PR builds we only want the latest commit to be tested, that's not true for try builds: each commit pushed to the branch is a different PR being tested, and we want multiple PRs to be tested in parallel if there is enough demand.

Fixes rust-lang#70569
@bors bors closed this as completed in 824dcd4 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietroalbini pietroalbini

Labels
A-github-actions Area: GitHub Actions (GHA) C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GHA: enable running multiple try builds at the same time pietroalbini/rust
1 participant
@pietroalbini