Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spam in PR checks about skipped builds #71178

Open
Mark-Simulacrum opened this issue Apr 15, 2020 · 3 comments
Open

Spam in PR checks about skipped builds #71178

Mark-Simulacrum opened this issue Apr 15, 2020 · 3 comments
Labels
A-github-actions Area: GitHub Actions (GHA) A-meta Area: Issues & PRs about the rust-lang/rust repository itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

In some PRs, though not all, we see 7 (!) skipped checks. These are annoying to scroll through.

image

I don't think this is a blocker, but would be nice to see fixed. It's also concerning that there appears to be some non-determinism (the above output is from #71147, but e.g. #71166 does not have it); IMO making sure we know what the cause of that non-determinism is a blocker, as non-determinism of skipped builds in CI is quite concerning :)

cc @pietroalbini
@Mark-Simulacrum Mark-Simulacrum added the A-github-actions Area: GitHub Actions (GHA) label Apr 15, 2020
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 15, 2020
@pietroalbini
Copy link
Member

Reported this to GitHub, they'll look into it.

@camelid camelid changed the title Spam in PR comments about skipped builds Spam in PR checks about skipped builds Oct 18, 2020
@camelid
Copy link
Member

camelid commented Oct 18, 2020

Any updates?

@pietroalbini
Copy link
Member

Not yet.

@camelid camelid added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-github-actions Area: GitHub Actions (GHA) A-meta Area: Issues & PRs about the rust-lang/rust repository itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonas-schievink @pietroalbini @Mark-Simulacrum @camelid