Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve help for code blocks invalid attributes #71469

Closed
GuillaumeGomez opened this issue Apr 23, 2020 · 1 comment
Closed

Improve help for code blocks invalid attributes #71469

GuillaumeGomez opened this issue Apr 23, 2020 · 1 comment
Assignees
@GuillaumeGomez
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

In #71408, we added a new lint to warn user in case of invalid (but close to existing) attributes. However, we say that "it might not be recognized as a rust block or...". This could be improved if we knew for sure that it is a rust block before actually throwing the message. The problem currently is that the order of the attributes actually matters, which makes it a bit trickier than one might expect.
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 23, 2020
@GuillaumeGomez GuillaumeGomez self-assigned this Apr 23, 2020
@GuillaumeGomez
Copy link
Member Author

I'm not sure there is much that can be done here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GuillaumeGomez