-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken MIR on HRTB #71546
Comments
Would be nice to figure out if this is a regression or not and if it is when has this regressed. @rustbot ping cleanup |
Hey Cleanup Crew ICE-breakers! This bug has been identified as a good cc @AminArria @chrissimpkins @contrun @DutchGhost @elshize @ethanboxx @h-michael @HallerPatrick @hdhoang @hellow554 @imtsuki @jakevossen5 @kanru @KarlK90 @LeSeulArtichaut @MAdrianMattocks @matheus-consoli @mental32 @nmccarty @Noah-Kennedy @pard68 @PeytonT @pierreN @Redblueflame @RobbieClarken @RobertoSnap @robjtede @SarthakSingh31 @senden9 @shekohex @sinato @spastorino @turboladen @woshilapin @yerke |
It has been present since at least 2019-08-01 according to bisect-rustc |
Simplified code to remove dependencies pub fn serialize_as_csv<V>(value: &V) -> Result<String, &str>
where
V: 'static,
for<'a> &'a V: IntoIterator,
for<'a> <&'a V as IntoIterator>::Item: ToString + 'static
{
let csv_str: String = value.into_iter().map(|elem| elem.to_string()).collect::<String>();
Ok(csv_str)
} This compiles for 1.20.0 and not for 1.30.0 (setting edition to 2015) I'll try and pinpoint at least the version where it causes the ICE |
From what I can tell the first time this ICE would happen is in 1.24.0
|
Assigning |
This comment has been minimized.
This comment has been minimized.
Triage: This ICE has been fixed in the latest nightly, I assume it's fixed by #73503. Marking as |
Wait, the original code and #71546 (comment) still triggers the ICE... glacier was tracking with #71546 (comment) but it seems the others encounter another roadblock. Dropping |
Re-add rust-lang/rust#71546 with another MCVE
Add HRTB-related regression test Closes rust-lang#59311 and cc rust-lang#71546 This closes the former but the test is taken from rust-lang#71546 (comment) since it seems they have the same cause and it's simplified.
Add HRTB-related regression test Closes rust-lang#59311 and cc rust-lang#71546 This closes the former but the test is taken from rust-lang#71546 (comment) since it seems they have the same cause and it's simplified.
Add HRTB-related regression test Closes rust-lang#59311 and cc rust-lang#71546 This closes the former but the test is taken from rust-lang#71546 (comment) since it seems they have the same cause and it's simplified.
…rrors Add regression test for rust-lang#71546 Closes rust-lang#71546 r? `@compiler-errors`
Rollup of 9 pull requests Successful merges: - rust-lang#94647 (Expose `get_many_mut` and `get_many_unchecked_mut` to HashMap) - rust-lang#97216 (Ensure we never consider the null pointer dereferencable) - rust-lang#97399 (simplify code of finding arg index in `opt_const_param_of`) - rust-lang#97470 (rustdoc: add more test coverage) - rust-lang#97498 (Corrected EBNF grammar for from_str) - rust-lang#97562 (Fix comment in `poly_project_and_unify_type`) - rust-lang#97580 (Add regression test for rust-lang#71546) - rust-lang#97611 (Tweak insert docs) - rust-lang#97616 (Remove an unnecessary `Option`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Playground: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=c0293ace3f56fd3d1d3c79ed971331f3
UPDATE: MCVE is here: #71546 (comment)
Code:
Crashes compiler with
The text was updated successfully, but these errors were encountered: