Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The list of impl on the left of rust docs are in the wrong order #71926

Closed
Eijebong opened this issue May 5, 2020 · 0 comments · Fixed by #71945
Closed

The list of impl on the left of rust docs are in the wrong order #71926

Eijebong opened this issue May 5, 2020 · 0 comments · Fixed by #71945
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Eijebong
Copy link
Contributor

Eijebong commented May 5, 2020

This can easily be seen here: https://docs.rs/diesel/1.4.4/diesel/deserialize/trait.FromSqlRow.html

The impl for the biggest tuple is at the top of the list but at the bottom of the page.

CC @GuillaumeGomez
@Eijebong Eijebong added the C-bug Category: This is a bug. label May 5, 2020
@jonas-schievink jonas-schievink added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 5, 2020
@GuillaumeGomez GuillaumeGomez self-assigned this May 5, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue May 6, 2020
Merged
RalfJung added a commit to RalfJung/rust that referenced this issue May 10, 2020
@RalfJung
Rollup merge of rust-lang#71945 - GuillaumeGomez:sort-impl-on-foreign…
ad2990c 
…-types-section, r=kinnison,ollie27

Sort "implementations on foreign types" section in the sidebar

Fixes rust-lang#71926.

We were sorting by the ID instead of sorting by the name. They're not in the same order as the implementations but I think it makes more sense this way considering this is what we do for the methods as well.

r? @kinnison

cc @rust-lang/rustdoc
@bors bors closed this as completed in d22c18b May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort "implementations on foreign types" section in the sidebar GuillaumeGomez/rust
3 participants
@jonas-schievink @GuillaumeGomez @Eijebong