Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for NonNull<[T]>::slice_from_raw_parts #71941

Closed
2 of 3 tasks
SimonSapin opened this issue May 6, 2020 · 6 comments · Fixed by #97506
Closed
2 of 3 tasks

Tracking Issue for NonNull<[T]>::slice_from_raw_parts #71941

SimonSapin opened this issue May 6, 2020 · 6 comments · Fixed by #97506
Labels
A-raw-pointers Area: raw pointers, MaybeUninit, NonNull A-slice Area: `[T]` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@SimonSapin
Copy link
Contributor

SimonSapin commented May 6, 2020

This is a tracking issue for the NonNull<[T]>::slice_from_raw_parts method proposed in PR #71940.
The feature gates for the issue are #![feature(nonnull_slice_from_raw_parts)], and #![feature(const_nonnull_slice_from_raw_parts)] for using as a const fn.

API

impl<T> NonNull<[T]> {
  pub const fn slice_from_raw_parts(data: NonNull<T>, len: usize) -> Self;
}

Docs: https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.slice_from_raw_parts

Steps

@SimonSapin SimonSapin added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels May 6, 2020
@JohnTitor JohnTitor added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label May 6, 2020
@KodrAus KodrAus added I-nominated A-slice Area: `[T]` Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. A-raw-pointers Area: raw pointers, MaybeUninit, NonNull labels Jul 29, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Mar 12, 2022

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Mar 12, 2022

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Mar 12, 2022
@bstrie
Copy link
Contributor

bstrie commented Apr 7, 2022

I'm willing to file the stabilization report for this if the library team is on board for stabilization.

@yaahc
Copy link
Member

yaahc commented Apr 7, 2022

I'm willing to file the stabilization report for this if the library team is on board for stabilization.

I'd certainly appreciate one!

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Apr 7, 2022
@rfcbot
Copy link

rfcbot commented Apr 7, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Apr 7, 2022
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 17, 2022
@rfcbot
Copy link

rfcbot commented Apr 17, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Apr 17, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 21, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Mar 27, 2023
…rom-raw-parts, r=m-ou-se,the8472

Stabilize `nonnull_slice_from_raw_parts`

FCP is done: rust-lang#71941 (comment)
Note that this doesn't const-stabilize `NonNull::slice_from_raw_parts` as `slice_from_raw_parts_mut` isn't const-stabilized yet. Given rust-lang#67456 and rust-lang#57349, it's not likely available soon, meanwhile, stabilizing only the feature makes some sense, I think.

Closes rust-lang#71941
@bors bors closed this as completed in 102bbbd Mar 27, 2023
thomcc pushed a commit to tcdi/postgrestd that referenced this issue Jun 1, 2023
…arts, r=m-ou-se,the8472

Stabilize `nonnull_slice_from_raw_parts`

FCP is done: rust-lang/rust#71941 (comment)
Note that this doesn't const-stabilize `NonNull::slice_from_raw_parts` as `slice_from_raw_parts_mut` isn't const-stabilized yet. Given #67456 and #57349, it's not likely available soon, meanwhile, stabilizing only the feature makes some sense, I think.

Closes #71941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-raw-pointers Area: raw pointers, MaybeUninit, NonNull A-slice Area: `[T]` B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants