Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a white glow or background on the favicon. #72165

Closed
FabienTregan opened this issue May 13, 2020 · 3 comments · Fixed by #75438
Closed

Add a white glow or background on the favicon. #72165

FabienTregan opened this issue May 13, 2020 · 3 comments · Fixed by #75438
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@FabienTregan
Copy link

Hi,

The Rust favicon is black and transparent. On dark browser themes, it is not easy to see. Since rust book and github also have this particularity, it's hard to find the tab among the other ones.

Not really important, but if it is cheap to fix that would help :)

My tabs right now:
image

@CryZe
Copy link
Contributor

CryZe commented May 17, 2020

GitHub seems to dynamically switch to a white icon for dark mode. Rust could probably do the same thing.

@FabienTregan
Copy link
Author

FabienTregan commented May 18, 2020

Though great, the prefers-color-scheme media feature is not widely used.
I guess most people don't know they can turn windows into dark mode and lot of people use dark themes in their browsers instead of default theme with dark os setting. prefers-color-scheme only work with the later for me.

@Elinvynia Elinvynia added A-meta Area: Issues & PRs about the rust-lang/rust repository itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-community labels May 20, 2020
@bors bors closed this as completed in 15efed4 Sep 25, 2020
@jonas-schievink jonas-schievink added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed T-community labels Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants