Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#72227 #72358

Closed
rust-highfive opened this issue May 19, 2020 · 7 comments · Fixed by #72531
Closed

miri no longer builds after rust-lang/rust#72227 #72358

rust-highfive opened this issue May 19, 2020 · 7 comments · Fixed by #72531
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #72227, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @nnethercote, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.

@RalfJung
Copy link
Member

Miri fix: rust-lang/miri#1420

@Elinvynia
Copy link
Contributor

This appears to be fixed

@RalfJung
Copy link
Member

RalfJung commented May 20, 2020

We fixed it in the Miri repo but have not yet updated the rustc repo for that. Let's keep the issue open until that happened.

@RalfJung RalfJung reopened this May 20, 2020
@Elinvynia
Copy link
Contributor

Apologies! Where should I check in the future to be sure it's fixed?

@RalfJung
Copy link
Member

No worries. :)
You can check the toolstate page: https://rust-lang-nursery.github.io/rust-toolstate/

(Or you can skip these miri issues if that's easier for you; I think I am taking care of them quite well -- though more eyes and more help are of course always appreciated.)

@Elinvynia
Copy link
Contributor

Thanks, gonna bookmark that. I was going through unlabeled issues which is how I stumbled here.

@RalfJung
Copy link
Member

Hm, we could maybe have the bot that creates them also automatically apply "A-miri C-bug" or so... Cc @kennytm

@Elinvynia Elinvynia added A-miri Area: The miri tool C-bug Category: This is a bug. labels May 20, 2020
@RalfJung RalfJung mentioned this issue May 24, 2020
@bors bors closed this as completed in ff991d6 May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants