-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run cargotest on quickcheck/proptest tests #73514
Comments
Yeah I think we've discussed this to some extent previously within infra team as part of our "what to do about cargotest" discussions. cc @nellshamrell in particular Not sure that we came to any conclusions though. |
Related: #70659 |
The |
This just bit me and took a lot of time as I triple-checked that after bors failing twice (!) in xsv, the same test actually works fine on my system. |
The xsv test suite seems to be full of quickcheck tests, so I think the only way to fix this is to remove xsv from cargotest (or to only run a short list of curated tests). |
@RalfJung See #70659 where there is some discussion fo changing the cargotest set. I think the last comment implies dropping xsv. |
Hm, that discussion seems to have stalled though. So to fix the immediate problem, I propose we do something like #99602. |
As part of our CI we run "cargotest" on a variety of ecosystem crates, making sure they successfully build and run tests.
Unfortunately, some of use stochastic tests like quickcheck, which means that a crate passing our CI one day may not necessarily mean it passes CI the next. Perhaps we should audit the tests being run and filter out ones like these?
See #73511 (comment) and BurntSushi/xsv#227
cc @rust-lang/release
The text was updated successfully, but these errors were encountered: