Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate running tests under helgrind #736

Closed
brson opened this issue Jul 25, 2011 · 4 comments
Closed

Investigate running tests under helgrind #736

brson opened this issue Jul 25, 2011 · 4 comments
Assignees
@brson
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@brson
Copy link
Contributor

brson commented Jul 25, 2011

I don't know much about this tool, but it might be useful for exercising our task system.
@eholk
Copy link
Contributor

eholk commented Jul 25, 2011

I've tried using helgrind a little. My perception was that there are far too many false positives to be useful. I think even a trivial "Hello World" written in C will cause helgrind errors from the C runtime.

@brson
Copy link
Contributor Author

brson commented Sep 23, 2011

I've been using helgrind quite often to debug task issues. There are some (likely) false positives, but they are consistent. With a suppressions file I think it could definitely be worthwhile to have an automated helgrind run of the testsuite.

@ghost ghost assigned brson Feb 8, 2012
@brson
Copy link
Contributor Author

brson commented Mar 2, 2012

I've added an --enable-helgrind option to the configure script. My project for the weekend is to make the build helgrind-clean.

@brson
Copy link
Contributor Author

brson commented Mar 19, 2012

The build is helgrind clean.

@brson brson closed this as completed Mar 19, 2012
@mexus mexus mentioned this issue May 7, 2017
Closed
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@joshlf
apple: Add VM_* constants from mach/vm_statistics.h
f8bfc6e 
Closes rust-lang#736
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@bors
Auto merge of rust-lang#749 - joshlf:mach-vm-flags, r=alexcrichton
e102a72 
apple: Add VM_* constants from mach/vm_statistics.h

Closes rust-lang#736.
pdietl pushed a commit to pdietl/rust that referenced this issue Apr 23, 2020
@Centril
Merge pull request rust-lang#736 from oli-obk/master
55a3f99 
Elaborate on how to use an extern static correctly
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws @tedinski
Handle non returning intrinsics (rust-lang#736)
5fbb4d7 
* Handle non returning intrinsics

* Newline in comment

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eholk @brson