Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap fails when Windows has uname command #73689

Closed
ajpaverd opened this issue Jun 24, 2020 · 0 comments · Fixed by #73691
Closed

Bootstrap fails when Windows has uname command #73689

ajpaverd opened this issue Jun 24, 2020 · 0 comments · Fixed by #73691
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@ajpaverd
Copy link
Contributor

bootstrap.py assumes Windows platforms do not have the uname command in the PATH. Although almost always true, this doesn't hold if the gnuwin32 tools are installed (e.g. for running LLVM tests), in which case the output is:

> uname -s
windows32
> uname -m
i686-pc

Bootstrap then gives the following error:

> python x.py test src/tools/tidy
Updating only changed submodules
Submodules updated in 0.56 seconds
unknown OS type: windows32
Build completed unsuccessfully in 0:00:00

@rustbot modify labels: +A-rustbuild
@ajpaverd ajpaverd added the C-bug Category: This is a bug. label Jun 24, 2020
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 24, 2020
@ajpaverd ajpaverd mentioned this issue Jun 24, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 26, 2020
@Manishearth
Rollup merge of rust-lang#73691 - ajpaverd:bootstrap-windows-73689, r…
a611a42 
…=Mark-Simulacrum

Bootstrap: detect Windows based on sys.platform

Closes rust-lang#73689.
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 26, 2020
@Manishearth
Rollup merge of rust-lang#73691 - ajpaverd:bootstrap-windows-73689, r…
ce114af 
…=Mark-Simulacrum

Bootstrap: detect Windows based on sys.platform

Closes rust-lang#73689.
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 26, 2020
@Manishearth
Rollup merge of rust-lang#73691 - ajpaverd:bootstrap-windows-73689, r…
eff76f3 
…=Mark-Simulacrum

Bootstrap: detect Windows based on sys.platform

Closes rust-lang#73689.
@bors bors closed this as completed in c18e919 Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bootstrap: detect Windows based on sys.platform ajpaverd/rust
2 participants
@ajpaverd @rustbot