Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt no longer builds after rust-lang/rust#74073 #74081

Closed
rust-highfive opened this issue Jul 6, 2020 · 12 comments · Fixed by #74245
Closed

rustfmt no longer builds after rust-lang/rust#74073 #74081

rust-highfive opened this issue Jul 6, 2020 · 12 comments · Fixed by #74245
Assignees
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #74073, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @Manishearth, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.

@rust-highfive rust-highfive added the C-bug Category: This is a bug. label Jul 6, 2020
@Manishearth
Copy link
Member

#74073 (comment)

@calebcartwright
Copy link
Member

calebcartwright commented Jul 9, 2020

@topecongiro @Xanewok not sure if either have you had a chance to look at this latest broken toolstate, but I'm a bit puzzled 🤔

I have not been able to reproduce the compile errors like I've always been able to do with previous broken toolstate issues for rustfmt, and have tested with the below toolchains and can successfully compile the same version of rustfmt successfully with each:

  • nightly-2020-07-09-x86_64-unknown-linux-gnu
  • nightly-2020-07-08-x86_64-unknown-linux-gnu
  • nightly-2020-07-07-x86_64-unknown-linux-gnu
  • nightly-2020-07-06-x86_64-unknown-linux-gnu
  • nightly-2020-07-05-x86_64-unknown-linux-gnu

Also checked on Windows (x86_64-pc-windows-msvc)

And AFAICT both rustfmt and rls components are available via rustup
https://rust-lang.github.io/rustup-components-history/
image

Am I missing something?

@topecongiro
Copy link
Contributor

@calebcartwright I could not reproduce the build error either.

@Manishearth Is there a link to the entire build log?

@Manishearth
Copy link
Member

Yes, https://github.com/rust-lang-ci/rust/runs/839815076, pick one of the builds that says "tools"

@calebcartwright
Copy link
Member

calebcartwright commented Jul 10, 2020

Thanks @Manishearth that was helpful

@topecongiro you've probably found it already, but here's some direct links to where the rustfmt build starts

https://github.com/rust-lang-ci/rust/runs/839579965#step:22:7922 (linux)
https://github.com/rust-lang-ci/rust/runs/839580000#step:22:7214 (windows)

One thing that jumps out to me is the different commit from the logs vs. what I'm seeing with the toolchain from rustup

note: rustc 1.46.0-nightly (0c03aee8b 2020-07-05) running on x86_64-unknown-linux-gnu
$ rustc --version
rustc 1.46.0-nightly (2753fab7c 2020-07-05)

Maybe we're lucky and it got fixed before the nightly publish that day 😆 (it didn't)

Here's a more recent run where the build is still failing
https://github.com/rust-lang-ci/rust/runs/852886590?check_suite_focus=true#step:22:7214

@oli-obk
Copy link
Contributor

oli-obk commented Jul 11, 2020

This only reproduces with debug assertions enabled while building rustc.

@da-x
Copy link
Member

da-x commented Jul 11, 2020

x.py build tools/rustfmt works after I apply https://github.com/da-x/rust/pull/new/fix-74081 . Should send a PR?

@da-x
Copy link
Member

da-x commented Jul 11, 2020

PR: #74240

Manishearth added a commit to Manishearth/rust that referenced this issue Jul 11, 2020
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 11, 2020
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 11, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 12, 2020
…arth

Rollup of 10 pull requests

Successful merges:

 - rust-lang#72920 (Stabilize `transmute` in constants and statics but not const fn)
 - rust-lang#73715 (debuginfo:  Mangle tuples to be natvis friendly, typedef basic types)
 - rust-lang#74066 (Optimize is_ascii for str and [u8].)
 - rust-lang#74116 (Fix cross compilation of LLVM to aarch64 Windows targets)
 - rust-lang#74167 (linker: illumos ld does not support --eh-frame-hdr)
 - rust-lang#74168 (Add a help to use `in_band_lifetimes` in nightly)
 - rust-lang#74197 (Reword incorrect `self` token suggestion)
 - rust-lang#74213 (Minor refactor for rustc_resolve diagnostics match)
 - rust-lang#74240 (Fix rust-lang#74081 and add the test case from rust-lang#74236)
 - rust-lang#74241 (update miri)

Failed merges:

r? @ghost
@bors bors closed this as completed in b929f72 Jul 12, 2020
@tmandry
Copy link
Member

tmandry commented Jul 22, 2020

Reopening: rustfmt still appears to be broken

@tmandry tmandry reopened this Jul 22, 2020
roxelo pushed a commit to sexxi-goose/rust that referenced this issue Jul 22, 2020
@calebcartwright
Copy link
Member

calebcartwright commented Jul 22, 2020

The original cause for this issue was #74236 which AIUI was indeed resolve by #74240 (and thus #74080 as well as rls was broken since it has rustfmt in its dep tree). However, a separate issue relative to the rustc-ap crates in rustfmt's dep tree popped up the same day #74240 was merged so we didn't discover the other issue til the next day and the bot didn't open a new issue.

We're on the last leg of updating the rustc-ap crates to fix that alternative issue, but just wanted to clarify the current broken toolstate is indeed a separate issue from the one discussed in this thread.

@tmandry
Copy link
Member

tmandry commented Jul 22, 2020

Thanks for working on that and for clarifying! I figured there was probably a secondary issue here.

I guess the toolstate site only sees nightlies so that's why it thinks it's been red since the 5th and never opened a new issue 🤔

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2020
Update rustfmt and rls

Closes rust-lang#74080, rust-lang#74081.

rls changes:
- deps: update racer and cargo

rustfmt changes:
- preparation for potential rustfmt 1.4.19 (rust-lang#4283)
- chore: backport 8157a3f0afe978d3e953420577f8344db7e905bf
- deps: bump rustc-ap to v669
- deps: bump rustc-ap-* to v668
- deps: bump rustc-ap* to v666
- Use correct span for match arms with the leading pipe and attributes (rust-lang#3975)
@calebcartwright
Copy link
Member

Don't think the close keyword from #74760 applied here, but would be good to get this closed too 👍

@tmandry tmandry closed this as completed Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
7 participants