Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining ordering strengths to atomic types #7422

Closed
Aatch opened this issue Jun 27, 2013 · 2 comments
Closed

Add remaining ordering strengths to atomic types #7422

Aatch opened this issue Jun 27, 2013 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@Aatch
Copy link
Contributor

Aatch commented Jun 27, 2013

We currently only have sequentially consistent (the strongest) and the acquire/release pair for ordering constraints. The intrinsics to support these have now been added, so the types should be extended to implement them.
@mnemotic mnemotic mentioned this issue Jun 30, 2013
Closed
@Xazax-hun Xazax-hun mentioned this issue Jul 23, 2013
Closed
@alchemy
Copy link

alchemy commented Oct 21, 2013

The atomic types defined in libstd/unstable/atomics.rs already have methods parametrized by memory ordering, that in turn call the appropriate intrinsic. Shouldn't this issue be closed?

@Aatch
Copy link
Contributor Author

Aatch commented Oct 21, 2013

@alchemy yes, well spotted

@Aatch Aatch closed this as completed Oct 21, 2013
osaut pushed a commit to osaut/rust that referenced this issue Oct 31, 2013
@bors
auto merge of rust-lang#7993 : Xazax-hun/rust/master, r=bblum
5102853 
Added missing memory orderings for atomic types. rust-lang#7422
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 15, 2021
@bors
Auto merge of rust-lang#7424 - dtolnay-contrib:macrobraces, r=llogiq
2abeac1 
Downgrade nonstandard_macro_braces to nursery

Due to the large number of crates impacted by rust-lang#7422, I don't think this lint can be enabled by default right now until the false positive is fixed.

---

changelog: remove [`nonstandard_macro_braces`] from default set of enabled lints
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 15, 2021
@bors
Auto merge of rust-lang#7431 - DevinR528:fix-macro-brace, r=llogiq
3cc6778 
Fix emitting in nested (proc_)macros for nonstandard_macro_braces lint

fixes rust-lang#7422

changelog: fixes false positives in [`nonstandard_macro_braces`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alchemy @Aatch