Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: theme-dependent logo system #74350

Closed
tesuji opened this issue Jul 15, 2020 · 2 comments · Fixed by #74361
Closed

rustdoc: theme-dependent logo system #74350

tesuji opened this issue Jul 15, 2020 · 2 comments · Fixed by #74361
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tesuji
Copy link
Contributor

tesuji commented Jul 15, 2020 •
edited
Loading

The current logo in Ayu theme is difficult to see:
image

As noted by @Cldfire in #71237 (comment):

Orange could potentially work, yes, and I agree that the logo will need improvement. However, I would say that this discussion is out of place for this PR; some sort of theme-dependent logo system needs to be added to rustdoc which needs to be discussed and implemented elsewhere, imo.

This issue is served as a tracking issue for that.

@rustbot modify labels: T-rustdoc
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 15, 2020
@Cldfire
Copy link
Contributor

Cldfire commented Jul 15, 2020

Thanks for making this issue! 😄

@Alexendoo Alexendoo added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 15, 2020
@GuillaumeGomez
Copy link
Member

The best solution would instead to provide a way to change the image border and/or background, which would be much simpler than having a different image for each theme.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 15, 2020
Merged
@Cldfire Cldfire mentioned this issue Jul 15, 2020
Closed
@bors bors closed this as completed in 38b2956 Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve doc theme logo display GuillaumeGomez/rust
5 participants
@Alexendoo @GuillaumeGomez @Cldfire @tesuji @rustbot