Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suitable tests for aarch64 for repr-transparent-aggregates-1.rs #74396

Closed
nikomatsakis opened this issue Jul 16, 2020 · 3 comments · Fixed by #130466
Closed

Add suitable tests for aarch64 for repr-transparent-aggregates-1.rs #74396

nikomatsakis opened this issue Jul 16, 2020 · 3 comments · Fixed by #130466
Assignees
@joaopaulocarreiro
Labels
E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. O-AArch64 Armv8-A or later processors in AArch64 mode T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jul 16, 2020 •
edited by rustbot
Loading

The motivation behind the "just ignoring" approach for this PR was based on the fact that I was looking at this as two independent tasks. One of them is to ignore this test for aarch64 (inevitable) and the other is to add suitable tests for the same target. The former is immediate, the latter requires a bit more effort, and is something that should follow.

But if we should proceed in a different way, that's fine too.

Originally posted by @joaopaulocarreiro in #73926 (comment)

This issue has been assigned to @joaopaulocarreiro via this comment.
@nikomatsakis
Copy link
Contributor Author

@rustbot assign @joaopaulocarreiro

@rustbot rustbot self-assigned this Jul 16, 2020
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. labels Jul 16, 2020
@nikomatsakis nikomatsakis mentioned this issue Jul 16, 2020
Merged
@jonas-schievink jonas-schievink added the O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state label Jul 16, 2020
@joaopaulocarreiro
Copy link
Contributor

I started taking a look at this. Adding the tests should be straight forward, but I am also interested in finding out why the llvm bitcode is being generated the way it is for aarch64.

@sundbry sundbry mentioned this issue Jan 19, 2021
Open
@dtolnay dtolnay assigned joaopaulocarreiro and unassigned rustbot Jan 27, 2022
@workingjubilee workingjubilee added O-AArch64 Armv8-A or later processors in AArch64 mode and removed O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state labels Aug 17, 2022
@Enselic
Copy link
Member

Enselic commented Aug 29, 2023

Triage: @joaopaulocarreiro: Are you still working on this?

@davidtwco davidtwco mentioned this issue Sep 17, 2024
Merged
@bors bors closed this as completed in b21581d Sep 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 18, 2024
@rust-timer
Unrolled build for rust-lang#130466
da32d82 
Rollup merge of rust-lang#130466 - davidtwco:aarch64-transparent-test, r=jieyouxu

tests: add repr/transparent test for aarch64

Fixes rust-lang#74396.

Moves `transparent-struct-ptr.rs` to `transparent-byval-struct-ptr.rs` and then adds a new `transparent-opaque-ptr.rs` for aarch64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaopaulocarreiro joaopaulocarreiro

Labels
E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. O-AArch64 Armv8-A or later processors in AArch64 mode T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: add repr/transparent test for aarch64 davidtwco/rust
6 participants
@Enselic @nikomatsakis @jonas-schievink @joaopaulocarreiro @workingjubilee @rustbot