-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 1.45.0 and above no longer install clippy #74431
Comments
Currently digging. Might be related:
|
This was unrelated. Turns out I get |
Ok, before we basically has |
I think either should_install should default to true if tools is empty (like should_build) or the condition for all optional tools should be As of now, if an optional tool builds fine, it gets installed no matter what the tools config contain, but as soon as it's no longer optional (like clippy in 1.45.0) it doesn't get installed anymore unless its name is explicitely listed in the tools config. This is a really weird behaviour |
Fedora added this to the configure line for the 1.45.0 upgrade:
That seems to be a workaround for the moment. |
That's what I ended up doing here too. The commented value in config.toml.example doesn't reflect the real default though |
This is a regression. See also the discussion at https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/installing.20clippy.20from.20extended.20build |
rustbuild: drop tool::should_install Always install when the build succeeds Fixes rust-lang#74431
rustbuild: drop tool::should_install Always install when the build succeeds Fixes rust-lang#74431
rustbuild: drop tool::should_install Always install when the build succeeds Fixes rust-lang#74431
Always install when the build succeeds Fixes rust-lang#74431 Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Always install when the build succeeds Fixes rust-lang#74431 Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
When updating from 1.44.1 to 1.45.0, clippy-driver and cargo-clippy are no longer installed by
./x.py install
.miri
andcargo-miri
weren't previously installed but they are now, and the opposite is true for clippy-driver and cargo-clippyThe text was updated successfully, but these errors were encountered: