Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

struct@ will resolve anything in the type namespace including things like mods and traits #74851

Closed
jyn514 opened this issue Jul 28, 2020 · 0 comments · Fixed by #75079
Closed

struct@ will resolve anything in the type namespace including things like mods and traits #74851

jyn514 opened this issue Jul 28, 2020 · 0 comments · Fixed by #75079
Assignees
@jyn514
Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Jul 28, 2020

Originally mentioned in #74430 (comment).

The following will work, but it seems like it shouldn't:

pub enum S {}

/// Link to [struct@S]
pub fn f() {}

Rustdoc should instead treat it as a resolution failure. This could be implemented using the disambiguator introduced in #74078.
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Jul 28, 2020
@jyn514 jyn514 mentioned this issue Jul 28, 2020
Merged
@jyn514 jyn514 self-assigned this Aug 2, 2020
@jyn514 jyn514 mentioned this issue Aug 3, 2020
Merged
@bors bors closed this as completed in 5b1ed09 Aug 7, 2020
@jyn514 jyn514 mentioned this issue Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyn514 jyn514

Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow linking to items with a mismatched disambiguator jyn514/rust
1 participant
@jyn514