Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crater runs for 1.46 #75142

Closed
Mark-Simulacrum opened this issue Aug 4, 2020 · 32 comments
Closed

Crater runs for 1.46 #75142

Mark-Simulacrum opened this issue Aug 4, 2020 · 32 comments
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Note: Please do not conduct triage on these runs with syncing with a release team member first. Thanks!

@Mark-Simulacrum Mark-Simulacrum added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Aug 4, 2020
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.46-1 start=1.45.2 end=beta-2020-07-24 mode=build-and-test cap-lints=warn p=10

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.46-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Aug 4, 2020
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.46-rustdoc-1 start=1.45.2 end=beta-2020-07-24 mode=rustdoc cap-lints=warn p=5

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.46-rustdoc-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.46-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment beta-1.46-1 has encountered an error: command Command { std: "/workspace/cargo-home/bin/rustup" "toolchain" "install" "1.45.2" "--profile" "minimal", kill_on_drop: false } failed
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.46-rustdoc-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member Author

@craterbot retry name=beta-1.46-1

@pietroalbini
Copy link
Member

@craterbot abort name=beta-1.46-rustdoc-1

@craterbot
Copy link
Collaborator

🗑️ Experiment beta-1.46-rustdoc-1 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 9, 2020
@pietroalbini
Copy link
Member

@craterbot retry name=beta-1.46-1

@craterbot
Copy link
Collaborator

🛠️ Experiment beta-1.46-1 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2020
@pietroalbini
Copy link
Member

@craterbot run name=beta-1.46-rustdoc-1 start=1.45.2 end=beta-2020-07-24 mode=rustdoc cap-lints=warn p=5

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.46-rustdoc-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.46-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.46-rustdoc-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.46-1 is completed!
📊 92 regressed and 65 fixed (115869 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 10, 2020
@Mark-Simulacrum
Copy link
Member Author

Finished triage:

No new issues (somewhat unsurprising, given how late this is in the cycle).

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.46-rustdoc-1 is completed!
📊 16 regressed and 17 fixed (116759 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member Author

One new issue (missed in the non-rustdoc run, not sure why though): #75453

@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=pr-75494-beta start=beta-2020-07-24 end=beta-2020-08-10 mode=check p=10

This is intended to catch unintended regressions introduced by #75494, backported as 1101496 in #75722. We could compare the SHA builds directly before/after that PR but it seems easier (and perhaps slightly safer) to just compare against the last beta we compared to 1.45.2; that should expose any potential regressions introduced since then (giving us slightly more coverage than necessary for checking just 1101496, but that's fine, it should be easy to identify whether they come from 1101496 afterwards).

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member Author

Gah...

@craterbot run name=pr-75494-beta start=beta-2020-07-24 end=beta-2020-08-10 mode=check-only p=10

@craterbot
Copy link
Collaborator

👌 Experiment pr-75494-beta created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2020
@Mark-Simulacrum
Copy link
Member Author

@craterbot edit end=master#cfbc6d4cf1acbac5c025acf8ed68929caa551df3

Hopefully that works...

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member Author

@craterbot name=pr-75494-beta end=master#cfbc6d4cf1acbac5c025acf8ed68929caa551df3

@craterbot
Copy link
Collaborator

📝 Configuration of the pr-75494-beta experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@spastorino
Copy link
Member

👍

@craterbot
Copy link
Collaborator

🚧 Experiment pr-75494-beta is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-75494-beta is completed!
📊 8 regressed and 7 fixed (118484 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 24, 2020
@Mark-Simulacrum
Copy link
Member Author

Crater came back clear.

Closing, we're good to go for 1.46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants