Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full-bootstrap builder doesn't test anything #75198

Closed
Mark-Simulacrum opened this issue Aug 5, 2020 · 3 comments · Fixed by #75708
Closed

full-bootstrap builder doesn't test anything #75198

Mark-Simulacrum opened this issue Aug 5, 2020 · 3 comments · Fixed by #75708
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

It's clocking in at 20 minutes and seems to be doing nothing -- I suspect that this might be a result of @jyn514's changes to x.py defaults but have not confirmed.

We should fix this.
@Mark-Simulacrum Mark-Simulacrum added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. P-high High priority labels Aug 5, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 5, 2020

(link to the PR: #73964)

@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 5, 2020
@pietroalbini
Copy link
Member

We discussed this during the infrastructure team meeting and agreed to remove the full-bootstrap builder. The builder doesn't provide much value for the stability of the project, as it rarely fails and we'd catch any failure it would prevent as soon as we promote nightly to beta.

@pietroalbini pietroalbini added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority and removed P-high High priority labels Aug 19, 2020
@pietroalbini
Copy link
Member

To fix this issue, the x86_64-gnu-full-bootstrap builders needs to be removed from the CI configuration and the Docker images directory.

@JohnTitor JohnTitor mentioned this issue Aug 19, 2020
Merged
@bors bors closed this as completed in de521cb Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the full-bootstrap builder from CI JohnTitor/rust
3 participants
@pietroalbini @Mark-Simulacrum @jyn514