Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./x.py run src/tools/expand-yaml-anchors/ is directory separator-sensitive #75709

Closed
JohnTitor opened this issue Aug 19, 2020 · 0 comments · Fixed by #80026
Closed

./x.py run src/tools/expand-yaml-anchors/ is directory separator-sensitive #75709

JohnTitor opened this issue Aug 19, 2020 · 0 comments · Fixed by #80026
Labels
C-bug Category: This is a bug. P-low Low priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@JohnTitor
Copy link
Member

On Windows, if we run ./x.py run src/tools/expand-yaml-anchors/, the script changes this

rust/.github/workflows/ci.yml

Line 8 in 11a44ad

# src/ci/github-actions/ci.yml

to src/ci/github-actions\ci.yml.

This isn't ideal, though it's quite a minor point. I think it'd be nice if we could make it insensitive.
@JohnTitor JohnTitor added C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 19, 2020
@JohnTitor JohnTitor added the P-low Low priority label Oct 14, 2020
@JohnTitor JohnTitor mentioned this issue Dec 14, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#80026 - JohnTitor:separator-insensitive, r=…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
da1e5eb 
…Mark-Simulacrum

expand-yaml-anchors: Make the output directory separator-insensitive

Fixes rust-lang#75709
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#80026 - JohnTitor:separator-insensitive, r=…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
77b6d15 
…Mark-Simulacrum

expand-yaml-anchors: Make the output directory separator-insensitive

Fixes rust-lang#75709
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#80026 - JohnTitor:separator-insensitive, r=…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a26389f 
…Mark-Simulacrum

expand-yaml-anchors: Make the output directory separator-insensitive

Fixes rust-lang#75709
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#80026 - JohnTitor:separator-insensitive, r=…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
34bd7c2 
…Mark-Simulacrum

expand-yaml-anchors: Make the output directory separator-insensitive

Fixes rust-lang#75709
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#80026 - JohnTitor:separator-insensitive, r=…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0cda9cd 
…Mark-Simulacrum

expand-yaml-anchors: Make the output directory separator-insensitive

Fixes rust-lang#75709
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#80026 - JohnTitor:separator-insensitive, r=…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6c7de3f 
…Mark-Simulacrum

expand-yaml-anchors: Make the output directory separator-insensitive

Fixes rust-lang#75709
@bors bors closed this as completed in f645e30 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. P-low Low priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expand-yaml-anchors: Make the output directory separator-insensitive JohnTitor/rust
1 participant
@JohnTitor