Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement an owned rope type #7628

Closed
thestinger opened this issue Jul 6, 2013 · 12 comments
Closed

implement an owned rope type #7628

thestinger opened this issue Jul 6, 2013 · 12 comments

Comments

@thestinger
Copy link
Contributor

This should just be a generic sequence type, and we can build an actual string on top of it later as we do on top of the byte vector representation. Of course, starting off with just sequences of bytes and extending it later would be fine.

bors added a commit that referenced this issue Jul 7, 2013
It's broken/unmaintained and needs to be rewritten to avoid managed
pointers and needless copies. A full rewrite is necessary and the API
will need to be redone so it's not worth keeping this around (#7628).

Closes #2236, #2744
@huonw
Copy link
Member

huonw commented Aug 19, 2013

Traige visit; still valid.

@bytbox
Copy link
Contributor

bytbox commented Jan 24, 2014

Is anyone currently working on this? I'm considering taking this up.

@huonw
Copy link
Member

huonw commented Jan 25, 2014

@bytbox I haven't heard of anyone working on it.

@swgillespie
Copy link
Contributor

Looks like this issue has been abandoned since 3 months ago, I'd like to take a swing at this if no one else is working on it.

@bytbox
Copy link
Contributor

bytbox commented Apr 10, 2014

Yup. Go right ahead.

Actually, here's my code, just in case you want to take a look. http://ix.io/bCF

@apollow
Copy link

apollow commented May 13, 2014

@swgillespie Are you still working on this? I've got interest in working on it if you aren't, just got a little bit of code worked on it so far

@swgillespie
Copy link
Contributor

I was pretty unsuccessful so by all means, go for it!

@ftxqxd
Copy link
Contributor

ftxqxd commented Jun 7, 2014

@apollow Have you stopped working on this? I’ve been playing around and I’ve got something working. (Here’s the code so far and an example of a rope’s graph.)

Should this be in its own crate or just in libstd (or libtext when that happens)?

@apollow
Copy link

apollow commented Jun 7, 2014

I'm still working on it, I'll take a look at your code as well, just got down conceptualizing how cords get balanced and working on compare to get some tests out, we should definitely collab on this!

@SSheldon
Copy link
Contributor

Wow, uh, my bad, I had assumed this was dead and had also been working on a basic implementation that I was about to pull request before I checked back on this issue 😛

Sounds like @apollow and @P1start have got this under control, but here's what I had in case there's anything you all find useful: https://github.com/SSheldon/rust/compare/master...rope

@apollow
Copy link

apollow commented Sep 25, 2014

Posting to reassure that this has not been abandoned! Finally got back some time to continue working on this: I hope to finish my portion by next week weds.

Update: Finally got something compiling for the balance portion of rope. Will get to testing soon!

Update Oct 20 and reminder for myself: Going to need a paired prog session with P1Start, then some finalizations on testing before any progress forward

@steveklabnik
Copy link
Member

I'm pulling a massive triage effort to get us ready for 1.0. As part of this, I'm moving stuff that's wishlist-like to the RFCs repo, as that's where major new things should get discussed/prioritized.

This issue has been moved to the RFCs repo: rust-lang/rfcs#653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants