-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement an owned rope type #7628
Comments
Traige visit; still valid. |
Is anyone currently working on this? I'm considering taking this up. |
@bytbox I haven't heard of anyone working on it. |
Looks like this issue has been abandoned since 3 months ago, I'd like to take a swing at this if no one else is working on it. |
Yup. Go right ahead. Actually, here's my code, just in case you want to take a look. http://ix.io/bCF |
@swgillespie Are you still working on this? I've got interest in working on it if you aren't, just got a little bit of code worked on it so far |
I was pretty unsuccessful so by all means, go for it! |
@apollow Have you stopped working on this? I’ve been playing around and I’ve got something working. (Here’s the code so far and an example of a rope’s graph.) Should this be in its own crate or just in |
I'm still working on it, I'll take a look at your code as well, just got down conceptualizing how cords get balanced and working on compare to get some tests out, we should definitely collab on this! |
Wow, uh, my bad, I had assumed this was dead and had also been working on a basic implementation that I was about to pull request before I checked back on this issue 😛 Sounds like @apollow and @P1start have got this under control, but here's what I had in case there's anything you all find useful: https://github.com/SSheldon/rust/compare/master...rope |
Posting to reassure that this has not been abandoned! Finally got back some time to continue working on this: I hope to finish my portion by next week weds. Update: Finally got something compiling for the balance portion of rope. Will get to testing soon! Update Oct 20 and reminder for myself: Going to need a paired prog session with P1Start, then some finalizations on testing before any progress forward |
I'm pulling a massive triage effort to get us ready for 1.0. As part of this, I'm moving stuff that's wishlist-like to the RFCs repo, as that's where major new things should get discussed/prioritized. This issue has been moved to the RFCs repo: rust-lang/rfcs#653 |
This should just be a generic sequence type, and we can build an actual string on top of it later as we do on top of the byte vector representation. Of course, starting off with just sequences of bytes and extending it later would be fine.
The text was updated successfully, but these errors were encountered: