-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Papercuts with #[bench] #7655
Comments
visiting for triage, email from 2013 sep 09. I agree, the above problems do indeed look like papercuts. |
also, it might be nice if the benchmark output right-aligned the decimal points in the numbers, for ease of quick comparison by eye. Doing the above in full generality is probably not worthwhile, since it requires knowing how many digits the maximal output has before you present any results. (It also requires knowing the longest test name, but that is easier to predict accurately. ;) But even just guessing a reasonable value for the max number of digits for |
…crichton r? anyone. You can see a bit more discussion on #7655. This does not close any ticket; I am just scratching an itch. Note in particular that I picked the value `{:>9} ns/iter` pretty much out of a hat. :)
Also, the presentation of |
The testing guide now has docs. The new result line is |
Fix derivable impl false positives fix rust-lang#7654 fix rust-lang#7655 changelog: none (not released)
#[bench]
functions that have the wrong type signature get silently ignored. This should be an error.#[bench]
s in it yields:The last line (0 passed/0 failed/0 ignored) is confusing here, since it did run something.
#[bench]
-- specifically that you have to compile with--test
and run with--bench
.The text was updated successfully, but these errors were encountered: