Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-downloading multiple identical LLVMs from CI #76587

Closed
Mark-Simulacrum opened this issue Sep 10, 2020 · 3 comments
Closed

Avoid re-downloading multiple identical LLVMs from CI #76587

Mark-Simulacrum opened this issue Sep 10, 2020 · 3 comments
Assignees
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Any LLVM submodule update landing means that we can switch rust-dev downloads added by #76349 to look for the LLVM submodule update rather than latest bors commit. That'll avoid spuriously redownloading essentially identical tarballs whenever someone rebases.

This is technically a QoL issue so does not block that PR, but is a rather major improvement since rebasing is quite common and the download is relatively hefty at ~20 MB.

@Mark-Simulacrum Mark-Simulacrum added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 10, 2020
@Mark-Simulacrum Mark-Simulacrum self-assigned this Sep 10, 2020
@jyn514 jyn514 added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Sep 10, 2020
@RalfJung
Copy link
Member

Does "rebasing" here include "pulling" (to get latest master before starting a new PR)? I am confused by the emphasis on rebasing.

@Mark-Simulacrum
Copy link
Member Author

Yes, any transition of "base" commit will cause a redownload. The option is currently off by default, though. I think most people would rather a download than a potential LLVM rebuild, and in any case this should get fixed in the next week or two I expect.

@Mark-Simulacrum
Copy link
Member Author

I believe this has since been fixed, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants