-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port pipes compiler to newsched #7666
Comments
This was referenced Jul 9, 2013
bors
added a commit
that referenced
this issue
Aug 1, 2013
The pipes compiler produced data types that encoded efficient and safe bounded message passing protocols between two endpoints. It was also capable of producing unbounded protocols. It was useful research but was arguably done before its proper time. I am removing it for the following reasons: * In practice we used it only for producing the `oneshot` protcol and the unbounded `stream` protocol and all communication in Rust use those. * The interface between the proto! macro and the standard library has a large surface area and was difficult to maintain through language and library changes. * It is now written in an old dialect of Rust and generates code which would likely be considered non-idiomatic. * Both the compiler and the runtime are difficult to understand, and likewise the relationship between the generated code and the library is hard to understand. Debugging is difficult. * The new scheduler implements `stream` and `oneshot` by hand in a way that will be significantly easier to maintain. This shouldn't be taken as an indication that 'channel protocols' for Rust are not worth pursuing again in the future. Concerned parties may include: @graydon, @pcwalton, @eholk, @bblum The most likely candidates for closing are #7666, #3018, #3020, #7021, #7667, #7303, #3658, #3295.
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 18, 2024
Move `clippy::module_name_repetitions` to `restriction` (from `pedantic`) Rational: - Too pedantic IMO, I use `#[warn(pedantic)]` in my personal projects, but then always allow this lint. The fact that we had a few `#[expect(clippy::module_name_repetitions)]` also underlines this point IMO - STD doesn't do this either. Examples: - std::vec::Vec - std::collections::vec_deque::VecDequeue - rust-lang#7666 commonly ignored --- changelog: Move [`module_name_repetitions`] to `restriction` (from `pedantic`) [rust-lang#13541](rust-lang/rust-clippy#13541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In newsched the pipe types are implemented by hand, but I don't necessarily want to delete the pipes compiler. Port it to the new scheduler.
Related to #5018
The text was updated successfully, but these errors were encountered: