Skip to content

Bitv::eq_vec should take &[bool] rather than ~[uint] #7711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emberian opened this issue Jul 11, 2013 · 1 comment
Closed

Bitv::eq_vec should take &[bool] rather than ~[uint] #7711

emberian opened this issue Jul 11, 2013 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@emberian
Copy link
Member

No description provided.

@chris-morgan
Copy link
Member

I'll have a go at this.

#7311 must be taken into account. cmr/dbaupp say it shouldn't be.

@chris-morgan chris-morgan mentioned this issue Jul 12, 2013
Closed
chris-morgan added a commit to chris-morgan/rust that referenced this issue Jul 12, 2013
@chris-morgan
Replace owned with borrowed pointer.
5b656cf 
As pointed out by cmr, there's no need for it to be owned there.
That was also in the original scope of rust-lang#7711.
bors added a commit that referenced this issue Jul 12, 2013
@bors
auto merge of #7730 : chris-morgan/rust/bitv-eq_vec-bool, r=cmr
5cc4e51 
Fixes #7711.
@bors bors closed this as completed in b8e95c4 Jul 12, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 7, 2021
@bors
Auto merge of rust-lang#7711 - camsteffen:depinfo-error, r=flip1995
9fc4b92 
Improve depinfo error

changelog: none

r? `@flip1995`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Bitv::eq_vec take &[bool] rather than ~[uint] chris-morgan/rust
2 participants
@chris-morgan @emberian