-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"make tidy" fails on windows #7723
Comments
Adding *.py to the list of extensions in .gitattributes fixes the problem. Another option would be adding a "# xfail-license" tag to licenseck.py like the other .py files have, or making tidy.py remove the CR characters before passing the contents to do_license_check. |
part of #8058 |
Small fix:
|
@klutzy I think diff --git a/src/etc/tidy.py b/src/etc/tidy.py
old mode 100644
new mode 100755
index 4815bc6..8f5abd4
--- a/src/etc/tidy.py
+++ b/src/etc/tidy.py
@@ -41,6 +41,7 @@ current_contents = ""
try:
for line in fileinput.input(file_names,
+ mode='rU',
openhook=fileinput.hook_encoded("utf-8")):
if fileinput.filename().find("tidy.py") == -1: is the more reliable solution. (It uses Python's built-in support to implicitly treat |
@huonw I thought yours is better, but actually it does not work. |
Could that be fixed on the .gitattributes?
|
@adridu59 In the case we have to force lf for nearly all source code, since |
Looking at some refs: EDIT: cc @thestinger |
This avoids default CRLF on msysgit for Windows which can cause trouble. Cf. https://help.github.com/articles/dealing-with-line-endings#text-eollf Closes #7723.
Fix manual_assert and match_wild_err_arm for `#![no_std]` and Rust 2021 Rust 2015 `std::panic!` has a wrapping block while `core::panic!` and Rust 2021 `std::panic!` does not. See rust-lang#88919 for details. Note that the test won't pass until clippy changes in rust-lang#88860 is synced. --- changelog: Fix [`manual_assert`] and [`match_wild_err_arm`] for `#![no_std]` and Rust 2021. Fixes rust-lang#7723
The file licenseck.py (ironically) fails its own license check, apparently because git uses CR LF line endings on windows for .py files with core.autocrlf enabled.
Also note that tidy is a target of check, so in turn this is making "make check" fail.
The text was updated successfully, but these errors were encountered: