Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest should remove .stderr for nonexistent revisions #77498

Closed
varkor opened this issue Oct 3, 2020 · 2 comments · Fixed by #121475
Closed

compiletest should remove .stderr for nonexistent revisions #77498

varkor opened this issue Oct 3, 2020 · 2 comments · Fixed by #121475
Assignees
@jieyouxu
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@varkor
Copy link
Member

varkor commented Oct 3, 2020 •
edited by rustbot
Loading

I added a normal ui test, generated a .stderr, then later added revisions to the test so that revA.stderr and revB.stderr files were generated. I forgot to manually remove the old .stderr file, and so I ended up committing it, despite it now being unused. It would be nice if compiletest automatically caught this situation (it probably also applies to when the list of revisions is changed).
@varkor varkor added the A-testsuite Area: The testsuite used to check the correctness of rustc label Oct 3, 2020
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Oct 3, 2020
@jyn514
Copy link
Member

jyn514 commented Apr 30, 2021

It might be easier to make this a tidy check.

@ehuss ehuss mentioned this issue May 31, 2022
Closed
@jieyouxu
Copy link
Member

@rustbot claim

@jieyouxu jieyouxu mentioned this issue Feb 22, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Mar 1, 2024
@workingjubilee
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
129dc66 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Mar 1, 2024
@workingjubilee
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
b4add6e 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
f8cb5af 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
a41f73b 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
dbfbd71 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
@bors bors closed this as completed in dcde08f Mar 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 1, 2024
@rust-timer
Unrolled build for rust-lang#121475
0e1373a 
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tidy check for .stderr/.stdout files for non-existent test revisions jieyouxu/rust
3 participants
@varkor @jyn514 @jieyouxu