Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.py setup should set changelog-seen #77572

Closed
jyn514 opened this issue Oct 5, 2020 · 2 comments · Fixed by #77746
Closed

x.py setup should set changelog-seen #77572

jyn514 opened this issue Oct 5, 2020 · 2 comments · Fixed by #77746
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 5, 2020

New contributors haven't use x.py before, so there's no reason for them to read the changelog: nothing has changed.

$ x.py setup
Updating only changed submodules
Submodules updated in 0.02 seconds
    Finished dev [unoptimized + debuginfo] target(s) in 0.09s
Welcome to the Rust project! What do you want to do with x.py?
a) Contribute to the standard library
b) Contribute to the compiler
c) Contribute to the compiler, and also modify LLVM or codegen
d) Install Rust from source
Please choose one (a/b/c/d): a
warning: x.py has made several changes recently you may want to look at
help: consider looking at the changes in `src/bootstrap/CHANGELOG.md`
note: to silence this warning, add `changelog-seen = 2` at the top of `config.toml`
`x.py` will now use the configuration at /home/joshua/rustc2/src/bootstrap/defaults/config.toml.library
To get started, try one of the following commands:
- `x.py check`
- `x.py build`
- `x.py test library/std`
- `x.py doc`
For more suggestions, see https://rustc-dev-guide.rust-lang.org/building/suggested.html
warning: x.py has made several changes recently you may want to look at
help: consider looking at the changes in `src/bootstrap/CHANGELOG.md`
note: to silence this warning, add `changelog-seen = 2` at the top of `config.toml`
note: this message was printed twice to make it more likely to be seen
$ x.py check
Updating only changed submodules
Submodules updated in 0.01 seconds
    Finished dev [unoptimized + debuginfo] target(s) in 0.09s
warning: x.py has made several changes recently you may want to look at
help: consider looking at the changes in `src/bootstrap/CHANGELOG.md`
note: to silence this warning, add `changelog-seen = 2` at the top of `config.toml`
Checking std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Oct 5, 2020
@winnsterx
Copy link
Contributor

I can tackle this.

@jyn514
Copy link
Member Author

jyn514 commented Oct 5, 2020

@winnayx that would be great! To get started, take a look at src/bootstrap/setup.rs. In addition to adding profile = "...", also add changelog-seen = VERSION. You'll have to move VERSION from bootstrap/bin/main.rs to bootstrap/lib.rs so you can access it in setup.

You should also double check that the changelog warning isn't printed during the setup command itself. I'm not sure exactly how to do that without reading the code, but I expect it to be a simple if cmd != "setup" or something like that.

@jyn514 jyn514 added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Oct 5, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this issue Oct 12, 2020
Fix `x.py setup` sets `changelog-seen`

Fixes rust-lang#77572 by setting changelog-seen in setup.rs
JohnTitor added a commit to JohnTitor/rust that referenced this issue Oct 12, 2020
Fix `x.py setup` sets `changelog-seen`

Fixes rust-lang#77572 by setting changelog-seen in setup.rs
@bors bors closed this as completed in dde9977 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants